Skip to content

Conversation

frankbuckley
Copy link
Contributor

Updates refs for SqlVector<T>.Null to reflect it returns Nullable<SqlVector<T>>.

Should fix #3520

Updates refs for SqlVector<T>.Null to reflect it returns Nullable<SqlVector<T>>.
@Copilot Copilot AI review requested due to automatic review settings July 26, 2025 12:58
@frankbuckley frankbuckley requested a review from a team as a code owner July 26, 2025 12:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the return type of the SqlVector<T>.Null property from SqlVector<T> to SqlVector<T>? (nullable) in both .NET Framework and .NET Core reference assemblies to correctly reflect that it returns a nullable SqlVector<T>.

  • Updates the property signature to use nullable reference types syntax
  • Maintains consistency between .NET Framework and .NET Core implementations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs Updates SqlVector<T>.Null property return type to nullable in .NET Framework reference assembly
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs Updates SqlVector<T>.Null property return type to nullable in .NET Core reference assembly

@benrr101
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the major note is that this change is updating the ref definition to match the implementation definition.

@apoorvdeshmukh apoorvdeshmukh added this to the 6.1.1 milestone Jul 30, 2025
@apoorvdeshmukh apoorvdeshmukh added the Area\Vector Use this for issues that are targeted for the Vector feature in the driver. label Jul 30, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.13%. Comparing base (b89ac49) to head (9061eb2).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b89ac49) and HEAD (9061eb2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b89ac49) HEAD (9061eb2)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   65.01%   59.13%   -5.89%     
==========================================
  Files         276      270       -6     
  Lines       62414    62098     -316     
==========================================
- Hits        40581    36722    -3859     
- Misses      21833    25376    +3543     
Flag Coverage Δ
addons ?
netcore 63.54% <ø> (-5.58%) ⬇️
netfx 60.90% <ø> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apoorvdeshmukh apoorvdeshmukh merged commit d1d8b23 into dotnet:main Jul 31, 2025
237 checks passed
This was referenced Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Vector Use this for issues that are targeted for the Vector feature in the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method not found: Microsoft.Data.SqlTypes.SqlVector`1.get_Null()'
3 participants