-
Notifications
You must be signed in to change notification settings - Fork 313
Update SqlVector<T>.Null refs #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SqlVector<T>.Null refs #3521
Conversation
Updates refs for SqlVector<T>.Null to reflect it returns Nullable<SqlVector<T>>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the return type of the SqlVector<T>.Null
property from SqlVector<T>
to SqlVector<T>?
(nullable) in both .NET Framework and .NET Core reference assemblies to correctly reflect that it returns a nullable SqlVector<T>
.
- Updates the property signature to use nullable reference types syntax
- Maintains consistency between .NET Framework and .NET Core implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs | Updates SqlVector<T>.Null property return type to nullable in .NET Framework reference assembly |
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs | Updates SqlVector<T>.Null property return type to nullable in .NET Core reference assembly |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the major note is that this change is updating the ref definition to match the implementation definition.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
- Coverage 65.01% 59.13% -5.89%
==========================================
Files 276 270 -6
Lines 62414 62098 -316
==========================================
- Hits 40581 36722 -3859
- Misses 21833 25376 +3543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updates refs for
SqlVector<T>.Null
to reflect it returnsNullable<SqlVector<T>>
.Should fix #3520