Backport 6.1 | SqlDecimal Extract Data #3467
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes for the SqlDecimal workaround in .NET Framework by removing the complex reflection-based decomposer and replacing it with a simple Data-property implementation, along with new unit tests to verify behavior.
- Simplified
SqlDecimalExtractDatato useSqlDecimal.Datainstead of reflection/serialization hacks - Removed unused
Reflection.Emit/Runtime.Serializationusings and the old helper class - Added unit tests covering
SqlDecimalExtractDatafor both null and non-null inputs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.netfx.cs | Replaced the reflection-based SqlDecimal decomposer with direct use of SqlDecimal.Data |
| src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlTypes/SqlTypeWorkaroundsTests.cs | Added tests for SqlDecimalExtractData, including null and non-null scenarios |
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlTypes/SqlTypeWorkarounds.netfx.cs:148
- [nitpick] The indentation of the
data1assignment is misaligned compared to the other assignments; please align it for consistent readability.
data1 = (uint)data[0];
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3467 +/- ##
===============================================
+ Coverage 66.91% 67.61% +0.69%
===============================================
Files 280 280
Lines 62386 62325 -61
===============================================
+ Hits 41745 42138 +393
+ Misses 20641 20187 -454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
For compliance reasons, we have to take a change to the SqlDecimal type workarounds in netfx.
Issues
N/A
Testing
Added unit tests for verifying the behavior of the sql type workarounds