fix wrong error message #3411
fix wrong error message #3411
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect enum type reference in the exception thrown by ConvertToPoolBlockingPeriod.
- Corrects the enum type passed to
ADP.InvalidEnumerationValue - Ensures the error message now references
PoolBlockingPeriodinstead ofApplicationIntent
Comments suppressed due to low confidence (1)
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/PoolBlockingUtilities.cs:131
- Consider adding a unit test to verify that an invalid
PoolBlockingPeriodvalue triggersInvalidEnumerationValueand correctly mentionsPoolBlockingPeriodin the exception message.
throw ADP.InvalidEnumerationValue(typeof(PoolBlockingPeriod), (int)eValue);
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@cheenamalhotra Pipeline errors seem unrelated? |
|
Yes, looks like that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
==========================================
- Coverage 68.33% 61.89% -6.45%
==========================================
Files 301 295 -6
Lines 65631 65321 -310
==========================================
- Hits 44849 40428 -4421
- Misses 20782 24893 +4111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixes #3410