Merge | SqlDataSourceEnumerator.Unix.cs #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used in netcore project
…re.Unix.cs in common project
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 65.07% 66.98% +1.90%
==========================================
Files 298 298
Lines 65515 65515
==========================================
+ Hits 42634 43884 +1250
+ Misses 22881 21631 -1250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
May 9, 2025
paulmedynski
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Quick and easy PR, moving the SqlDataSourceEnumerator.Unix.cs file from the netcore project to the common project. It was renamed to SqlDataSourceEnumerator.netcore.Unix.cs to follow the pattern I've been using.
Also renamed SqlDataSourceEnumeratorManagedHelper.cs to SqlDataSourceEnumeratorManagedHelper.netcore.cs to indicate it is only used in the netcore project. The class was also wrapped in an
#if NETTesting: Project still builds locally, there were no functional changes to the code.