Merge | Port SqlDataSourceConverter, widen test coverage #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add test coverage for this type converter (and for the netfx-only NetworkLibraryConverter.)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
samsharma2700
approved these changes
Apr 29, 2025
|
Thanks. Could CI be re-triggered though please? I've just noticed an issue I'd missed with |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 72.97% 66.25% -6.73%
==========================================
Files 298 292 -6
Lines 57002 56690 -312
==========================================
- Hits 41600 37558 -4042
- Misses 15402 19132 +3730
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3243 reminded me that we didn't completely port the TypeConverters for
SqlConnectionStringBuilder.This PR makes sure that the WinForms PropertyGrid behaviour is consistent between .NET Core and .NET Framework for the
DataSourceand theFailoverPartnerproperties.Both this and
NetworkLibraryConverteralso had very poor code coverage; I've added tests to broaden this.I'd appreciate a CI & Codecov run.