Merge | SqlFileStream.Unix #3306
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the unsupported SqlFileStream implementation by moving it from its previous location into a new file (SqlFileStream.netcore.Unix.cs) and updating its formatting to use expression-bodied members, with conditional compilation applied via #if NET.
- Renamed and relocated the unsupported SqlFileStream implementation for Unix.
- Updated documentation reference paths and applied expression-bodied syntax for consistency.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlTypes/SqlFileStream.netcore.Unix.cs | Implements the Unix-specific unsupported SqlFileStream with updated formatting and documentation integration. |
| src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlFileStream.Unsupported.cs | Removed to consolidate the unsupported implementation into the common project. |
Files not reviewed (1)
- src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj: Language not supported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
==========================================
- Coverage 72.97% 72.94% -0.04%
==========================================
Files 298 298
Lines 57002 57003 +1
==========================================
- Hits 41600 41578 -22
- Misses 15402 15425 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description: Another easy one, moving the SqlFileStream.Unsupported to the common project. In this instance, the file was renamed to SqlFileStream.netcore.Unix, wrapped in a
#if NET, the documentation links were fixed, and the formatting was spaced out a bit (and changed to expression bodies)Testing: File moved, it's just throws unsupported exceptions, nothing super important is happening.