Merge | Align TdsExecuteRPC between netcore and netfx #2985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2985 +/- ##
===========================================
- Coverage 92.58% 72.65% -19.93%
===========================================
Files 6 285 +279
Lines 310 59198 +58888
===========================================
+ Hits 287 43013 +42726
- Misses 23 16185 +16162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
approved these changes
Nov 25, 2024
1691c1b to
8c15c00
Compare
|
I've re-applied the changes on current main |
benrr101
approved these changes
Dec 3, 2024
|
Closing and replacing with #3292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up TdsExecuteRPC to multiple functions to align netcore and netfx
Part of #2953