Align ADP.IsEmpty -> string.IsNullOrEmpty #2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrr101
approved these changes
Nov 4, 2024
cheenamalhotra
approved these changes
Nov 5, 2024
|
@cheenamalhotra Could you also run this pipeline? Thx :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@benrr101 IsNullOrEmpty did not exist in .NET Framework 1 😅 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2961 +/- ##
==========================================
+ Coverage 72.31% 72.34% +0.02%
==========================================
Files 288 288
Lines 59660 59660
==========================================
+ Hits 43145 43162 +17
+ Misses 16515 16498 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply changes ADP.IsEmpty to string.IsNullOrEmpty to align netfx with netcore
Part of #2953