Skip to content

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 2, 2024

An easy to review change that removes redundant namespace definitions to align netfx/netcore

Part of #2953

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised there aren't more instances in this file...

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 4, 2024
@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (9d5ca32) to head (675f7fe).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   72.31%   72.32%           
=======================================
  Files         288      288           
  Lines       59660    59660           
=======================================
+ Hits        43145    43147    +2     
+ Misses      16515    16513    -2     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.41% <ø> (-0.01%) ⬇️
netfx 70.70% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 5, 2024
@benrr101 benrr101 merged commit 13e0f9c into dotnet:main Nov 5, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants