Skip to content

[5.2] Add | Cache TokenCredential objects to take advantage of token caching (#2380) #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2024
Merged

[5.2] Add | Cache TokenCredential objects to take advantage of token caching (#2380) #2775

merged 2 commits into from
Aug 15, 2024

Conversation

dauinsight
Copy link
Contributor

Backports: #2380

@dauinsight dauinsight added the Enhancement 💡 Issues that are feature requests for the drivers we maintain. label Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.41237% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (ec5ad66) to head (5de1f5f).
Report is 1 commits behind head on release/5.2.

Files Patch % Lines
...SqlClient/ActiveDirectoryAuthenticationProvider.cs 80.41% 19 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release/5.2    #2775      +/-   ##
===============================================
+ Coverage        72.64%   72.69%   +0.05%     
===============================================
  Files              310      310              
  Lines            61881    61947      +66     
===============================================
+ Hits             44953    45034      +81     
+ Misses           16928    16913      -15
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.85% <80.41%> (+0.02%) ⬆️
netfx 70.27% <80.41%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dauinsight dauinsight merged commit 3fee17d into dotnet:release/5.2 Aug 15, 2024
150 checks passed
@David-Engel David-Engel mentioned this pull request Oct 23, 2024
Open
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
This was referenced Aug 4, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

+2 more reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@arellegue arellegue arellegue approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Enhancement 💡 Issues that are feature requests for the drivers we maintain.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dauinsight @David-Engel @DavoudEshtehari @arellegue