Skip to content

[5.1.5] Fix | Enable reading AE date as DateOnly (#2275) #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2024
Merged

[5.1.5] Fix | Enable reading AE date as DateOnly (#2275) #2324

merged 2 commits into from
Jan 27, 2024

Conversation

JRahnama
Copy link
Contributor

Backports PR #2275 to 5.1.5

fixes #2274

cc: @ErikEJ

@ErikEJ
Fix | Enable reading AE date as DateOnly (#2275)
4bc35fe 
# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
@JRahnama JRahnama added the Area\Netcore Issues that apply only to .NET runtime or the 'netcore' project folder. label Jan 26, 2024
H-Yeo
H-Yeo approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@H-Yeo H-Yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 26, 2024

LGTM

@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/5.1@b92637e). Click here to learn what that means.

❗ Current head 4bc35fe differs from pull request most recent head ba1124e. Consider uploading reports for the commit ba1124e to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##             release/5.1    #2324   +/-   ##
==============================================
  Coverage               ?   64.97%           
==============================================
  Files                  ?      293           
  Lines                  ?    61549           
  Branches               ?        0           
==============================================
  Hits                   ?    39993           
  Misses                 ?    21556           
  Partials               ?        0
Flag Coverage Δ
addons 0.00% <0.00%> (?)
netcore 69.99% <0.00%> (?)
netfx 62.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama JRahnama merged commit 01a589e into dotnet:release/5.1 Jan 27, 2024
@JRahnama JRahnama deleted the backport2275 branch March 8, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

+2 more reviewers

@arellegue arellegue arellegue approved these changes

@H-Yeo H-Yeo H-Yeo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area\Netcore Issues that apply only to .NET runtime or the 'netcore' project folder.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JRahnama @ErikEJ @David-Engel @arellegue @H-Yeo