[5.1.1] Fix | Addressing failure on providing correct error message when symmetric key decryption fails using Always Encrypted #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etric key decryption fails using Always Encrypted. (dotnet#1948)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 5.1-servicing #1968 +/- ##
=================================================
- Coverage 70.83% 69.86% -0.98%
=================================================
Files 292 292
Lines 61732 61736 +4
=================================================
- Hits 43730 43133 -597
- Misses 18002 18603 +601
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
JRahnama
approved these changes
Mar 27, 2023
Kaur-Parminder
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting fix to the 5.1-servicing branch. This fix addresses the issue where the decrypt fail exception was not thrown properly caused by a partial read issue resulting a TDS invalid token exception instead. These changes are based on #1948