Merge to shared - TdsParserSessionPool #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence in the netcore project
… remove the netfx version of the file
Kaur-Parminder
approved these changes
May 26, 2022
Codecov ReportBase: 71.47% // Head: 71.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 71.47% 71.44% -0.04%
==========================================
Files 292 290 -2
Lines 61302 61066 -236
==========================================
- Hits 43814 43626 -188
+ Misses 17488 17440 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserSessionPool.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserSessionPool.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserSessionPool.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Oct 5, 2022
David-Engel
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261. Merged netfx into netcore for TdsParserSessionPool, and moving it to shared src and updating file to conform with coding style. I left a TODO comment on line 203 because I noticed that #1520 is merging TdsParserStateObject into shared src, and once that change is in we can update this so it uses the property instead of the internal field.