Skip to content

Merging SqlConnectionStringBuilder code bases #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 18, 2021
Merged

Merging SqlConnectionStringBuilder code bases #1349

merged 7 commits into from
Oct 18, 2021

Conversation

DavoudEshtehari
Copy link
Contributor

  • related issue: Possible mergeable classes for merging code bases #1261.
  • Common Type: SqlConnectionStringBuilder
    • I used if-directives for separation.
    • I rearranged members and grouped them in Fields, Private Methods, and Public APIs.
    • Null reference members have been removed.
    • I chose the better implementation from the existing codebases besides applying some code improvements.

@DavoudEshtehari DavoudEshtehari added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Oct 14, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Oct 14, 2021
@DavoudEshtehari DavoudEshtehari mentioned this pull request Oct 14, 2021
Open
@cheenamalhotra cheenamalhotra merged commit 9942523 into dotnet:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder

+3 more reviewers

@Wraith2 Wraith2 Wraith2 left review comments

@johnnypham johnnypham johnnypham left review comments

@JRahnama JRahnama JRahnama approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@DavoudEshtehari @Wraith2 @cheenamalhotra @johnnypham @JRahnama