Skip to content

Fixed ActiveDirectoryAuthenticationProvider constructors. #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fixed ActiveDirectoryAuthenticationProvider constructors. #1328

merged 1 commit into from
Oct 13, 2021

Conversation

smichtch
Copy link
Contributor

@smichtch smichtch commented Oct 8, 2021

ActiveDirectoryAuthenticationProvider constructors initialize applicationClientId and deviceCodeFlowCallbackMethod correctly.

Fixes #1327

@smichtch smichtch force-pushed the fix-aad-auth-provider-ctor branch from dbf8f81 to eb12243 Compare October 13, 2021 16:30
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview3 milestone Oct 13, 2021
@cheenamalhotra cheenamalhotra merged commit d8b59b6 into dotnet:main Oct 13, 2021
@smichtch smichtch deleted the fix-aad-auth-provider-ctor branch October 13, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder

+3 more reviewers

@johnnypham johnnypham johnnypham approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.

ActiveDirectoryAuthenticationProvider constructors implemented incorrectly
5 participants
@smichtch @cheenamalhotra @johnnypham @JRahnama @DavoudEshtehari