Skip to content

Move to Shared for SqlException.cs #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2021
Merged

Move to Shared for SqlException.cs #1300

merged 8 commits into from
Oct 15, 2021

Conversation

lcheunglci
Copy link
Contributor

Relates to #1261 . Merged the SqlException.cs from netfx into netcore, move it into the shared src and updated it to conform with the coding style.

@DavoudEshtehari DavoudEshtehari mentioned this pull request Sep 30, 2021
Open
@DavoudEshtehari DavoudEshtehari added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Sep 30, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Sep 30, 2021
@JRahnama JRahnama merged commit 04cdeff into dotnet:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@johnnypham johnnypham johnnypham approved these changes

@Kaur-Parminder Kaur-Parminder Kaur-Parminder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@lcheunglci @johnnypham @Kaur-Parminder @JRahnama @DavoudEshtehari