Move into shared for TimeoutTimer.cs #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
You probably don't want to include it in the netfx project file until it's used by something in the netfx build. |
Thanks for the recommendation. I did verify it's being referenced in the netfx project in |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
… rest of the ProviderBase in the netfx csproj
cheenamalhotra
approved these changes
Sep 22, 2021
JRahnama
approved these changes
Sep 28, 2021
DavoudEshtehari
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Just a minor naming rule violation here: internal static readonly long s_infiniteTimeout = 0;
Plus an extra blank line at the end of TimeoutTimer.cs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to issue #1261, I moved the TimeoutTimer.cs from the dotnet to src and updated the reference from the netfx version