Skip to content

Merging common code bases DBConnectionOptions #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2021
Merged

Merging common code bases DBConnectionOptions #1279

merged 3 commits into from
Oct 6, 2021

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Sep 22, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Sep 22, 2021
@DavoudEshtehari DavoudEshtehari force-pushed the Adhoc/MergeDbConnectionOptions branch from 4bc6b4c to 951b357 Compare September 23, 2021 17:30
@DavoudEshtehari DavoudEshtehari mentioned this pull request Sep 23, 2021
Open
JRahnama
JRahnama reviewed Sep 29, 2021
View reviewed changes
@cheenamalhotra cheenamalhotra merged commit 6ac1e49 into dotnet:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@yyjdelete yyjdelete yyjdelete left review comments

@johnnypham johnnypham johnnypham approved these changes

@JRahnama JRahnama JRahnama approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@DavoudEshtehari @yyjdelete @johnnypham @JRahnama @cheenamalhotra