Move into shared for SQLResource.cs #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project to reference it
…in the correct section in the netfx csproj
cheenamalhotra
approved these changes
Sep 28, 2021
JRahnama
approved these changes
Sep 28, 2021
…SNI-SQLResource # Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/Common/SQLResource.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #1261 . I moved the netfx
SQLResource.csto src and updated reference in the dotnet project to reference it. I chose to use the .NET Framework version of SQLResource because it uses the StringsHelper to shorten any strings that exceeds 1024 characters and replace it with ellipsis. I check in the Strings.Resx for the English locale and didn't notice anything that would exceed that limit, however, I haven't check the other locales, so I don't think dotnet core would be affected by this.