Skip to content

Transient Fault Handling is disabled by default with SqlConnection.OpenAsync() #1982

New issue
New issue
Closed
#1983
Closed
Transient Fault Handling is disabled by default with SqlConnection.OpenAsync()#1982
#1983
@cheenamalhotra

Description

@cheenamalhotra
cheenamalhotra
opened on Apr 5, 2023

Describe the bug

When opening a connection with SqlConnection.OpenAsync(), transient fault handling is not enabled.
Test with placing breakpoints on below locations:

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

Line 1859 in a5ad838

_applyTransientFaultHandling = (!overrides.HasFlag(SqlConnectionOverrides.OpenWithoutRetry) && retry == null && connectionOptions != null && connectionOptions.ConnectRetryCount > 0);

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

Line 1888 in a5ad838

_applyTransientFaultHandling = (retry == null && connectionOptions != null && connectionOptions.ConnectRetryCount > 0);

_applyTransientFaultHandling is set to false as retry is not null in this method when opening connection asynchronously.
When opening connection with Open(), _applyTransientFaultHandling is set to true as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions