Skip to content

Conversation

christiannagel
Copy link
Contributor

Refactor WakeLock.PInvoke for compatibility with the ARM CPU #2745

Replaced SimpleReasonString field from REASON_CONTEXT with a union, REASON_CONTEXT_UNION.
The ARM CPU is more strict with unions.
Within unions, strings are not allowed, thus using a pointer to a string, with updated allocation within PowerCreateRequest.



Replaced `SimpleReasonString` field from `REASON_CONTEXT` with a union, REASON_CONTEXT_UNION.
The ARM CPU is more strict with unions.
Within unions, strings are not allowed, thus using a pointer to a string, with updated allocation within PowerCreateRequest.
@christiannagel
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christiannagel!

@timcassell timcassell merged commit 68feeb4 into dotnet:master Jun 7, 2025
8 checks passed
@timcassell timcassell added this to the v0.15.1 milestone Jun 7, 2025
@christiannagel christiannagel deleted the christiannagel/wakelock-arm-2745 branch June 8, 2025 07:27
This was referenced Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running benchmark with BenchmarkDotNet 15.0 fails with Fatal error. 0xC0000005, WakeLock
2 participants