Skip to content

Update used go version in docs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update used go version in docs #10

wants to merge 1 commit into from

Conversation

kk3939
Copy link

@kk3939 kk3939 commented Feb 20, 2023 •
edited
Loading

Now, I found Go v1.17.0 is installed in action and the error is occurred.
Then, I saw original repository(staticcheck-action) and found maintainer is planning to updating this action to v1.3.0
https://github.com/dominikh/staticcheck-action/blob/master/CHANGES.md

However, the default branch README and action.yml was not updated. That's why I open the pull request.

When it's time to update, I hope you take this in.

@kk3939 kk3939 marked this pull request as ready for review February 20, 2023 01:46
@dominikh
Copy link
Owner

I believe the README and action.yml are correct as is. The action itself still only requires Go 1.16, and you can install older versions of Staticcheck that still support Go 1.16. It's only the latest version of Staticcheck that requires Go 1.19.

@kk3939
Copy link
Author

kk3939 commented Feb 21, 2023

@dominikh
It was originally because I felt the following incongruity.
In README, This is written.

The latest release of Staticcheck works with the last two minor releases of Go.

Golang@v1.20.0 is released now and staticcheck-action@v1.2.0 uses 1.17.x.
0c5d998#diff-fab4d7fb461bc6fbe9587f6c03fff98102b1c744145edcf2a993f2ff7cb05a0dL80

I was confused that a different version of go was installed from the version supported by the latest version.

The line in question does not mean the latest version but older versions such as v1.1.0 support v1.16.0?

The action itself requires at least Go 1.16.

@dominikh dominikh closed this in 64a2c8e Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kk3939 @dominikh