-
-
Notifications
You must be signed in to change notification settings - Fork 390
Comparing changes
Open a pull request
base repository: dominikh/go-tools
base: v0.3.0
head repository: dominikh/go-tools
compare: v0.3.1
- 17 commits
- 23 files changed
- 1 contributor
Commits on Mar 31, 2022
-
go/ast/astutil: don't panic trying to copy FuncType
In gh-1134, I argued in favour of extending CopyExpr to use reflection to handle all types, under the assumption that we missed many types. I have now decided against that, for two reasons: 1. There weren't many unhandled types left 2. We cannot copy comments because of limitations in go/ast, and it seems better to refuse generating suggested fixes than to swallow comments. This is a general problem, but function literals are particularly likely to contain comments. Thus, we just add FuncType to the list of types we cannot copy. The effect is that several checks in the quickfix package will not generate suggested fixes in some cases. Closes gh-1134 (cherry picked from commit 8af8898)
Configuration menu - View commit details
-
Copy full SHA for d0c6d29 - Browse repository at this point
Copy the full SHA d0c6d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5322218 - Browse repository at this point
Copy the full SHA 5322218View commit details
Commits on Apr 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0d4b693 - Browse repository at this point
Copy the full SHA 0d4b693View commit details
Commits on Apr 4, 2022
-
staticcheck: delete unused function objectName
(cherry picked from commit 98c3eca)
Configuration menu - View commit details
-
Copy full SHA for d296b34 - Browse repository at this point
Copy the full SHA d296b34View commit details -
staticcheck: fix test case for Go 1.17
(cherry picked from commit 273d35f)
Configuration menu - View commit details
-
Copy full SHA for c285ca0 - Browse repository at this point
Copy the full SHA c285ca0View commit details -
lintcmd: make binary output OS agnostic
We were storing absolute paths and full token.Position in the binary output. This works fine when merging multiple runs from the same OS, but not so when dealing with multiple OSs, which have different path separators and different absolute paths. We also have to zero out token.Position.Offset to handle different newlines on different OSs. (cherry picked from commit 87cceb1)
Configuration menu - View commit details
-
Copy full SHA for 1846305 - Browse repository at this point
Copy the full SHA 1846305View commit details -
SA4008: change merge behavior to MergeIfAll
MergeIfAny leads to false positives if the loop condition is a stub in some build configurations. (cherry picked from commit 3d6c86f)
Configuration menu - View commit details
-
Copy full SHA for 0e678cb - Browse repository at this point
Copy the full SHA 0e678cbView commit details -
Make use of the new -merge feature (cherry picked from commit 59d7a28)
Configuration menu - View commit details
-
Copy full SHA for 1adb261 - Browse repository at this point
Copy the full SHA 1adb261View commit details
Commits on Apr 9, 2022
-
lintcmd: don't accidentally shadow variable in type assertion
(cherry picked from commit 5be6941)
Configuration menu - View commit details
-
Copy full SHA for ec23881 - Browse repository at this point
Copy the full SHA ec23881View commit details -
staticcheck/fakexml: delete dead assignment
(cherry picked from commit bc5bdcd)
Configuration menu - View commit details
-
Copy full SHA for 3dfe275 - Browse repository at this point
Copy the full SHA 3dfe275View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90a3456 - Browse repository at this point
Copy the full SHA 90a3456View commit details
Commits on Apr 24, 2022
-
unused: don't crash on generic composite literals
(cherry picked from commit 1cd2556)
Configuration menu - View commit details
-
Copy full SHA for 0ccdb5c - Browse repository at this point
Copy the full SHA 0ccdb5cView commit details -
unused: detect struct conversions involving generics
(cherry picked from commit d694aad)
Configuration menu - View commit details
-
Copy full SHA for 90804df - Browse repository at this point
Copy the full SHA 90804dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 880a503 - Browse repository at this point
Copy the full SHA 880a503View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0ef32b - Browse repository at this point
Copy the full SHA c0ef32bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a39c65d - Browse repository at this point
Copy the full SHA a39c65dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 136263d - Browse repository at this point
Copy the full SHA 136263dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.3.0...v0.3.1