Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dominikh/go-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0
Choose a base ref
...
head repository: dominikh/go-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.1
Choose a head ref
  • 17 commits
  • 23 files changed
  • 1 contributor

Commits on Mar 31, 2022

  1. go/ast/astutil: don't panic trying to copy FuncType

    In gh-1134, I argued in favour of extending CopyExpr to use reflection
    to handle all types, under the assumption that we missed many types.
    I have now decided against that, for two reasons:
    
    1. There weren't many unhandled types left
    2. We cannot copy comments because of limitations in go/ast, and it
    seems better to refuse generating suggested fixes than to swallow
    comments. This is a general problem, but function literals are
    particularly likely to contain comments.
    
    Thus, we just add FuncType to the list of types we cannot copy. The
    effect is that several checks in the quickfix package will not generate
    suggested fixes in some cases.
    
    Closes gh-1134
    
    (cherry picked from commit 8af8898)
    dominikh committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    d0c6d29 View commit details
    Browse the repository at this point in the history
  2. SA1026, SA5008: don't loop forever when marshaling cyclic pointer type

    Closes gh-1202
    
    (cherry picked from commit 4a64968)
    dominikh committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    5322218 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. SA4023, analysis/facts/typedness: with generics, MakeInterface can re…

    …turn untyped nil
    
    Closes gh-1242
    
    (cherry picked from commit e88e689)
    dominikh committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    0d4b693 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. staticcheck: delete unused function objectName

    (cherry picked from commit 98c3eca)
    dominikh committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d296b34 View commit details
    Browse the repository at this point in the history
  2. staticcheck: fix test case for Go 1.17

    (cherry picked from commit 273d35f)
    dominikh committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c285ca0 View commit details
    Browse the repository at this point in the history
  3. lintcmd: make binary output OS agnostic

    We were storing absolute paths and full token.Position in the binary
    output. This works fine when merging multiple runs from the same OS, but
    not so when dealing with multiple OSs, which have different path
    separators and different absolute paths. We also have to zero out
    token.Position.Offset to handle different newlines on different OSs.
    
    (cherry picked from commit 87cceb1)
    dominikh committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    1846305 View commit details
    Browse the repository at this point in the history
  4. SA4008: change merge behavior to MergeIfAll

    MergeIfAny leads to false positives if the loop condition is a stub in
    some build configurations.
    
    (cherry picked from commit 3d6c86f)
    dominikh committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    0e678cb View commit details
    Browse the repository at this point in the history
  5. Update CI

    Make use of the new -merge feature
    
    (cherry picked from commit 59d7a28)
    dominikh committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    1adb261 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. lintcmd: don't accidentally shadow variable in type assertion

    (cherry picked from commit 5be6941)
    dominikh committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    ec23881 View commit details
    Browse the repository at this point in the history
  2. staticcheck/fakexml: delete dead assignment

    (cherry picked from commit bc5bdcd)
    dominikh committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    3dfe275 View commit details
    Browse the repository at this point in the history
  3. unused: don't get stuck chasing mutually recursive type instantiations

    Closes gh-1247
    
    (cherry picked from commit 6dbb73d)
    dominikh committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    90a3456 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. unused: don't crash on generic composite literals

    (cherry picked from commit 1cd2556)
    dominikh committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    0ccdb5c View commit details
    Browse the repository at this point in the history
  2. unused: detect struct conversions involving generics

    (cherry picked from commit d694aad)
    dominikh committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    90804df View commit details
    Browse the repository at this point in the history
  3. staticcheck/fakejson: don't complain about maps with generic keys

    Updates gh-1256
    
    (cherry picked from commit 311d97b)
    dominikh committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    880a503 View commit details
    Browse the repository at this point in the history
  4. ST1021: handle type names that are also articles

    Closes gh-1187
    
    (cherry picked from commit 416f0a8)
    dominikh committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    c0ef32b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a39c65d View commit details
    Browse the repository at this point in the history
  6. Version 2022.1.1 (v0.3.1)

    dominikh committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    136263d View commit details
    Browse the repository at this point in the history
Loading