-
Notifications
You must be signed in to change notification settings - Fork 80
Simplify record keys #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify record keys #131
Conversation
Ah, yes, because |
I am not sure if |
I think the |
I like the |
@KonstantinGasser @joshuaherrera Not sure what was going through my mind when suggesting |
So I would also suggest @. In fact the @ is also used for example in systemd to pass params to a service file. |
Thanks for all the feedback! I also think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
Sorry for the delay - this is going to be merged now! |
closes #116
I implemented the features discussed in #116, but I needed to change the "marker" of the ID from
#
to*
. Otherwise, the argument seems to be ignored. I don't know if it's my terminal or the go library or something else, but thearg[0]
is empty when the input starts with a#
.This begs two questions: Are you okay with the
*
as a marker, or would you prefer something else? And should we change the header of the list record command accordingly, to avoid confusion?