Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dolmen/github-keygen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.010
Choose a base ref
...
head repository: dolmen/github-keygen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.011
Choose a head ref
  • 14 commits
  • 2 files changed
  • 1 contributor

Commits on Feb 23, 2014

  1. Create ~/.ssh/ if missing

    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    7d945b8 View commit details
    Browse the repository at this point in the history

  2. Add config for SSH on https port at ssh.github.com 

    https://help.github.com/articles/using-ssh-over-the-https-port
Add special case for ssh.github.com to connect to port 443 (https port)
instead of SSH standard port.
Add aliases *.ssh.github.com that connect to port 443.
Fixes issue #12.
    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    7166c56 View commit details
    Browse the repository at this point in the history

  3. Update links to Github help pages

    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    f09512b View commit details
    Browse the repository at this point in the history

  4. Add support for '@github' suffix for users on the command line 

    The suffix is still optional.
This is a first step to add support for other targets than Github.
    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    a192c07 View commit details
    Browse the repository at this point in the history

  5. Bump $VERSION to 1.011

    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    db3d943 View commit details
    Browse the repository at this point in the history

  6. README: changelog for release 1.011

    @dolmen
    dolmen committed Feb 23, 2014
    Configuration menu
    Copy the full SHA
    bde9b93 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2014

  1. Move config rules for ssh.github.com above *.github.com 

    ssh_config parsing rules keep only the first value set to an option. Our
rule order was broken for hosts gist.github.com and ssh.github.com (and
their *.gist.github.com and *.ssh.github.com aliases).
Really fixes #12.
    @dolmen
    dolmen committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    961e673 View commit details
    Browse the repository at this point in the history

  2. Fix update of known_hosts_github file 

    The size check had to be updated for the update to be triggered.

Also, the known_host entry for ssh.github.com is now specific to port
443: ssh checks this entry first (before a more generic
"ssh.github.com" entry), so this *may* speed-up connection.
    @dolmen
    dolmen committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    6643269 View commit details
    Browse the repository at this point in the history

  3. Add *.443.github.com as aliases to *.ssh.github.com

    @dolmen
    dolmen committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    6ecd845 View commit details
    Browse the repository at this point in the history

  4. Minor optimization: group multiple 'use constant'

    @dolmen
    dolmen committed Feb 24, 2014
    Configuration menu
    Copy the full SHA
    d9a4cf5 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2014

  1. Fixes #13: default github account was lost 

    When we run again github-keygen after a default account has been
previously selected (--default) the default was not preserved.
#13

That was broken by 7f3054e (released in v1.004).
    @dolmen
    dolmen committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    81d973d View commit details
    Browse the repository at this point in the history

  2. Optimizations in config parsing

    @dolmen
    dolmen committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    346e030 View commit details
    Browse the repository at this point in the history

  3. README: changelog for fixed issue #13

    @dolmen
    dolmen committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    66dc371 View commit details
    Browse the repository at this point in the history

  4. Release v1.011

    @dolmen
    dolmen committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    7cbccf0 View commit details
    Browse the repository at this point in the history
Loading