fix: add missing symbol types, include symbols #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitjson
commented
Aug 6, 2020
| @@ -26,6 +26,7 @@ const common = { | |||
| pilcrow2: '❡', | |||
| pilcrow: '¶', | |||
| plusMinus: '±', | |||
| question: '?', | |||
There was a problem hiding this comment.
By the way: the question symbol was exactly the same between the windows and other sets, so I moved it to the common set.
|
Last change – I also added tsdocs to each union-typed symbol to make hovers a little nicer. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds the missing symbols to the exported TypeScript types. (I've been working on enquirer/enquirer#307, and some of the remaining issues are missing symbols here.)
I also included the precise symbols rather than defining each as a
string– this makes the autocomplete a little nicer when selecting a symbol.