Skip to content

Conversation

kariy
Copy link
Member

@kariy kariy commented Jul 18, 2025

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Summary by CodeRabbit

  • Chores
    • Updated version lists to include "1.6.3" for improved version tracking.

Copy link
Contributor

coderabbitai bot commented Jul 18, 2025

Walkthrough

Ohayo sensei! This update modifies the versions.json file by prepending the "1.6.3" version to the "katana" version arrays for the keys "1.6.0-alpha.0", "1.6.0-alpha.1", "1.6.0-alpha.2", and "1.6.0". No other keys or values, including "torii" arrays, were changed.

Changes

File(s) Change Summary
versions.json Added "1.6.3" as the first entry in "katana" arrays for "1.6.0-alpha.0", ".1", ".2", and "1.6.0" keys.

Possibly related PRs

Suggested reviewers

  • glihm
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch updatekatana

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22ca0c7 and 9d9bbc2.

📒 Files selected for processing (1)
  • versions.json (4 hunks)
🔇 Additional comments (1)
versions.json (1)

32-40: Ohayo sensei! katana 1.6.3 inserted correctly, order preserved
The new version is prepended consistently in every relevant list, keeping the arrays in descending semantic-version order. JSON syntax stays valid and no duplicate entries were introduced inside each array.

Also applies to: 55-62, 77-84, 99-106

Comment on lines 32 to +40
"1.6.0-alpha.0": {
"katana": ["1.6.2", "1.6.1", "1.6.0", "1.6.0-alpha.1", "1.6.0-alpha.0"],
"katana": [
"1.6.3",
"1.6.2",
"1.6.1",
"1.6.0",
"1.6.0-alpha.1",
"1.6.0-alpha.0"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Quick sanity-check that the referenced build exists
Before merging, it’s worth confirming that katana@1.6.3 is published and downloadable; otherwise CI / downstream tooling may fail at install time.

If the endpoint returns a version object (HTTP 200), we’re good to go; a 404 indicates the tag hasn’t been published yet.


🏁 Script executed:

#!/bin/bash
# Verify that katana 1.6.3 is resolvable on crates.io / npm / PyPI (adjust as needed).
# Example shown for crates.io; replace the URL if katana lives elsewhere.
curl -s https://crates.io/api/v1/crates/katana/1.6.3 | jq '.version' 

Length of output: 73


Ohayo, sensei! Let’s also verify if katana@1.6.3 is published on npm and PyPI before we proceed:


🏁 Script executed:

#!/bin/bash
# Check npm registry for katana@1.6.3
npm_version=$(curl -s https://registry.npmjs.org/katana/1.6.3 | jq -r .version // "null")
echo "npm: $npm_version"

# Check PyPI for katana@1.6.3
pypi_version=$(curl -s https://pypi.org/pypi/katana/1.6.3/json | jq -r .info.version // "null")
echo "pypi: $pypi_version"

Length of output: 415


Ohayo, sensei! Action Required: Ensure katana@1.6.3 is published before merging

The crates.io check returned null, and npm/PyPI lookups also failed—meaning version 1.6.3 isn’t available yet. Please:

• Verify and publish katana@1.6.3 to all needed registries (crates.io, npm, PyPI).
• Confirm with reliable commands, e.g.:
cargo search katana or curl -s https://crates.io/api/v1/crates/katana/1.6.3 | jq '.version'
npm view katana@1.6.3 version
pip index versions katana | grep 1.6.3
• Only then update versions.json (lines 32–40) to include 1.6.3.

🤖 Prompt for AI Agents
In versions.json around lines 32 to 40, the version katana@1.6.3 is listed but
not yet published to the required registries. Before merging, verify that
katana@1.6.3 is published on crates.io, npm, and PyPI using appropriate
commands. Once confirmed, update versions.json to include 1.6.3; if not
published, remove or hold off on adding this version until publication is
complete.

@kariy kariy merged commit 8964db9 into main Jul 18, 2025
1 check passed
@kariy kariy deleted the updatekatana branch July 18, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant