-
Notifications
You must be signed in to change notification settings - Fork 204
chore: add katana@1.6.3 #3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add katana@1.6.3 #3283
Conversation
WalkthroughOhayo sensei! This update modifies the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
versions.json
(4 hunks)
🔇 Additional comments (1)
versions.json (1)
32-40
: Ohayo sensei!katana 1.6.3
inserted correctly, order preserved
The new version is prepended consistently in every relevant list, keeping the arrays in descending semantic-version order. JSON syntax stays valid and no duplicate entries were introduced inside each array.Also applies to: 55-62, 77-84, 99-106
"1.6.0-alpha.0": { | ||
"katana": ["1.6.2", "1.6.1", "1.6.0", "1.6.0-alpha.1", "1.6.0-alpha.0"], | ||
"katana": [ | ||
"1.6.3", | ||
"1.6.2", | ||
"1.6.1", | ||
"1.6.0", | ||
"1.6.0-alpha.1", | ||
"1.6.0-alpha.0" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Quick sanity-check that the referenced build exists
Before merging, it’s worth confirming that katana@1.6.3
is published and downloadable; otherwise CI / downstream tooling may fail at install time.
If the endpoint returns a version object (HTTP 200), we’re good to go; a 404 indicates the tag hasn’t been published yet.
🏁 Script executed:
#!/bin/bash
# Verify that katana 1.6.3 is resolvable on crates.io / npm / PyPI (adjust as needed).
# Example shown for crates.io; replace the URL if katana lives elsewhere.
curl -s https://crates.io/api/v1/crates/katana/1.6.3 | jq '.version'
Length of output: 73
Ohayo, sensei! Let’s also verify if katana@1.6.3 is published on npm and PyPI before we proceed:
🏁 Script executed:
#!/bin/bash
# Check npm registry for katana@1.6.3
npm_version=$(curl -s https://registry.npmjs.org/katana/1.6.3 | jq -r .version // "null")
echo "npm: $npm_version"
# Check PyPI for katana@1.6.3
pypi_version=$(curl -s https://pypi.org/pypi/katana/1.6.3/json | jq -r .info.version // "null")
echo "pypi: $pypi_version"
Length of output: 415
Ohayo, sensei! Action Required: Ensure katana@1.6.3 is published before merging
The crates.io check returned null, and npm/PyPI lookups also failed—meaning version 1.6.3 isn’t available yet. Please:
• Verify and publish katana@1.6.3 to all needed registries (crates.io, npm, PyPI).
• Confirm with reliable commands, e.g.:
– cargo search katana
or curl -s https://crates.io/api/v1/crates/katana/1.6.3 | jq '.version'
– npm view katana@1.6.3 version
– pip index versions katana | grep 1.6.3
• Only then update versions.json
(lines 32–40) to include 1.6.3.
🤖 Prompt for AI Agents
In versions.json around lines 32 to 40, the version katana@1.6.3 is listed but
not yet published to the required registries. Before merging, verify that
katana@1.6.3 is published on crates.io, npm, and PyPI using appropriate
commands. Once confirmed, update versions.json to include 1.6.3; if not
published, remove or hold off on adding this version until publication is
complete.
Description
Related issue
Tests
Added to documentation?
Checklist
scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit