-
Notifications
You must be signed in to change notification settings - Fork 204
chore(versions): update torii versions #3261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughOhayo sensei! This update modifies the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"torii": ["1.5.8", "1.5.7", "1.5.6", "1.5.5", "1.5.4", "1.5.3", "1.5.2", "1.5.1", "1.5.0"] | ||
}, | ||
"1.6.0-alpha.0": { | ||
"katana": ["1.6.0-alpha.1", "1.6.0-alpha.0"], | ||
"torii": ["1.5.6", "1.5.5", "1.5.4", "1.5.3", "1.5.2", "1.5.1", "1.5.0"] | ||
"torii": ["1.5.8", "1.5.7", "1.5.6", "1.5.5", "1.5.4", "1.5.3", "1.5.2", "1.5.1", "1.5.0"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ohayo sensei – please confirm the freshly-added Torii versions are live and correctly ordered
The lists look fine syntactically, but before merging it’s worth double-checking that 1.5.8
and 1.5.7
are published and that no newer patch slipped in out of band.
🏁 Script executed:
#!/bin/bash
# Verify that the two new Torii versions exist on the registry
set -euo pipefail
for v in 1.5.8 1.5.7; do
echo "Checking torii@$v ..."
npm view torii@$v version # replace with the correct scope if applicable
done
Length of output: 503
Ohayo sensei – Torii@1.5.8 isn’t live on npm, please verify or update
It looks like running
npm view torii@1.5.8 version
returned a 404, so 1.5.8
(and possibly 1.5.7
) aren’t published yet. Before merging, please:
• Confirm that 1.5.8
and 1.5.7
are available on the registry (or publish them).
• If they’re not ready, remove or adjust those entries in versions.json (lines 20–25).
You might also use a non-failing check to catch both at once:
#!/usr/bin/env bash
for v in 1.5.8 1.5.7; do
if npm view torii@"$v" version > /dev/null 2>&1; then
echo "✔ torii@$v is published"
else
echo "✖ torii@$v not found"
fi
done
🤖 Prompt for AI Agents
In versions.json around lines 20 to 25, the versions 1.5.8 and 1.5.7 of the
torii package are listed but are not published on npm, causing potential errors.
Verify the availability of these versions on the npm registry; if they are not
published yet, remove or replace these versions in the torii arrays with only
published versions to prevent referencing non-existent releases.
Summary by CodeRabbit