This repository was archived by the owner on Jul 30, 2018. It is now read-only.
Fixes vdom issues with selecting insert before and rendering widgets after they have been destroyed #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and skip widgets that have been queued but are destroyed
matt-gadd
approved these changes
May 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
vdom.tswas processing widgets that had been detached by a previous render but had been invalidated themselves and therefore were already on the queue. To resolve this the call to "detach" widgets has been moved from request idle callback to be sync when processing renders. When a node it removed,onDetachis called which removes all references such as an injector that would otherwise invalidate the detached widget and also removes the instance from theinstanceMapso that it will not get rendered again.Also when processing nodes from higher in the dnode tree, there was a possibility that an incorrect reference (to the old node) could be used as the render process was traversing down the tree of the parent stored at the point of time it was rendered. If the lower component had rendered itself since the reference the node had in it's tree would be outdated. This changes
updatechildren to always look for a node from theinstanceMapas that will always be the latest version of the widget and used this for processing removal.