This repository was archived by the owner on Jul 30, 2018. It is now read-only.
Remove second generic on query #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78c9e28 to
ae3649b
Compare
Current coverage is 98.08% (diff: 100%)@@ master #43 diff @@
==========================================
Files 17 17
Lines 1002 993 -9
Methods 6 6
Messages 0 0
Branches 177 177
==========================================
- Hits 983 974 -9
Misses 1 1
Partials 18 18
|
b2e2b5b to
bd70bf6
Compare
agubler
reviewed
Dec 12, 2016
| @@ -94,7 +94,7 @@ function createFilterHelper<T>(filters: FilterChainMember<T>[], serializer: (fil | |||
| return data.filter(this.test); | |||
| }, | |||
| filterChain: filters, | |||
| toString(this: Filter<T>, filterSerializer?: ((query: Query<any, any>) => string) | ((filter: Filter<T>) => string)) { | |||
| toString(this: Filter<T>, filterSerializer?: ((query: Query<any>) => string) | ((filter: Filter<T>) => string)) { | |||
There was a problem hiding this comment.
can the Query type use T ? (query: Query<T>) => string)
| toString(querySerializer?: (query: Query<any, any>) => string): string; | ||
| export interface Query<T> { | ||
| apply(data: T[]): T[]; | ||
| toString(querySerializer?: (query: Query<any>) => string): string; |
agubler
approved these changes
Dec 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: cleanup
Description:
Resolves #39 by simplifying the
Querytype to only have one generic. This depends on the changes in #32 and will need to be merged after it.Related Issue: #39
Please review this checklist before submitting your PR: