This repository was archived by the owner on Jul 30, 2018. It is now read-only.
Make file names and exports more consistent #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cf9b28 to
2701434
Compare
Current coverage is 99.79% (diff: 100%)@@ master #32 diff @@
==========================================
Files 17 17
Lines 979 985 +6
Methods 5 5
Messages 0 0
Branches 162 162
==========================================
+ Hits 977 983 +6
Misses 1 1
Partials 1 1
|
kitsonk
reviewed
Oct 31, 2016
| @@ -26,7 +25,7 @@ function toString(...segments: string[]): string { | |||
| }); | |||
| } | |||
|
|
|||
| export function createPointer(...segments: string[]): JsonPointer { | |||
| function createPointer(...segments: string[]): JsonPointer { | |||
There was a problem hiding this comment.
shouldn't we name this createJsonPointer to reflect the modules name?
6065c44 to
3c6b5b5
Compare
Use `createX` pattern for all modules that export factory functions. Export factory function as default for all modules that export factory functions. Move query interface to interfaces file, to separate it from the createCompoundQuery factory.
3c6b5b5 to
af8226f
Compare
This was referenced Nov 7, 2016
Merged
Use `createX` pattern for all modules that export factory functions. Export factory function as default for all modules that export factory functions. Move query interface to interfaces file, to separate it from the createCompoundQuery factory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactor
Description: Makes file and export names, and default exports, more consistent. This doesn't contain any changes in functionality.
Related Issue: #???
Please review this checklist before submitting your PR:
Use
createXpattern for all modules that export factoryfunctions.
Export factory function as default for all modules that
export factory functions.
Move query interface to interfaces file, to separate it
from the createCompoundQuery factory.