Allow specifying a custom top-level label key for the caddy proxy #7812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e789fff to
acf2c85
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow to set a custom label key (
caddyby default) per app for Caddy Proxy.Why
For more complex Caddy configurations, it may be necessary to set a different key.
Example: https://github.com/lucaslorentz/caddy-docker-proxy/wiki/Use-on_demand_tls
How
A new set option called
label-key, which can be used per app.The
caddyvalue is used by default to prevent issues for existing configurations.I was unable to run tests locally, but I tried it on an existing dokku server with a Caddy proxy set.