Skip to content

Improve error handling in docker operations #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devopswithnaman
Copy link

  • Replace boolean return values with proper error handling in dockerTag and dockerPush functions
  • Add detailed error context including Docker command exit codes and stderr output
  • Remove TODO comments and improve error messages for better debugging
  • Fix error message formatting in defer function

This addresses the TODO comments for better error handling and provides users with actionable error information when Docker registry operations fail.

@josegonzalez josegonzalez changed the base branch from master to 0.36-release July 2, 2025 05:28
- Replace boolean return values with proper error handling in dockerTag and dockerPush functions
- Add detailed error context including Docker command exit codes and stderr output
- Remove TODO comments and improve error messages for better debugging
- Fix error message formatting in defer function

This addresses the TODO comments for better error handling and provides
users with actionable error information when Docker registry operations fail.

Closes: #XXXX
@josegonzalez josegonzalez force-pushed the fix/registry-error-handling branch from 75466a0 to 8b07e92 Compare July 2, 2025 05:34
@josegonzalez josegonzalez changed the title fix(registry): improve error handling in docker operations Improve error handling in docker operations Jul 2, 2025
@josegonzalez josegonzalez merged commit c4d700c into dokku:0.36-release Jul 4, 2025
176 of 178 checks passed
@josegonzalez josegonzalez mentioned this pull request Jul 4, 2025
@josegonzalez josegonzalez added this to the v0.36.0 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants