Use docker cliconfig package to load and save logins #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I saw this issue early on, but didn't have a chance to fix yet! Will try it out and get it merged soon. |
|
Done! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Docker (1.7 onwards) use
~/.docker/config.jsonto store login information. The current logic seems to be looking at the wrong path (configinstead ofconfig.json). Additionally, the format of the json file has changed; all logins are now nested inside theauthsproperty.This changes the login comand to use the updated functions from
github/docker/docker/cliconfigfor loading and saving docker configs. I had to add some code to support writing to the old.dockercfgformat as well, based on which file was loaded.