Skip to content

consensus: Add chain ID to block version #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2021
Merged

consensus: Add chain ID to block version #2560

merged 1 commit into from
Nov 15, 2021

Conversation

rnicoll
Copy link
Contributor

@rnicoll rnicoll commented Sep 10, 2021

No description provided.

@rnicoll rnicoll added this to the 1.21 milestone Sep 10, 2021
@rnicoll rnicoll marked this pull request as ready for review September 10, 2021 08:35
@rnicoll rnicoll requested a review from a team September 10, 2021 08:35
@rnicoll rnicoll force-pushed the 1.21-chain-id branch 3 times, most recently from f5bfb95 to f172f83 Compare September 10, 2021 19:39
@rnicoll rnicoll self-assigned this Sep 11, 2021
@patricklodder patricklodder mentioned this pull request Sep 23, 2021
Merged
patricklodder
patricklodder requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, have only some minor findings.

@rnicoll
Copy link
Contributor Author

rnicoll commented Nov 14, 2021

@patricklodder Should be ready for re-review

patricklodder
patricklodder approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rnicoll rnicoll merged commit aa61e37 into dogecoin:1.21-dev Nov 15, 2021
@rnicoll rnicoll deleted the 1.21-chain-id branch November 15, 2021 09:19
@patricklodder patricklodder mentioned this pull request Nov 29, 2021
Closed
@patricklodder patricklodder mentioned this pull request May 11, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricklodder patricklodder patricklodder approved these changes

Assignees

@rnicoll rnicoll

Labels
None yet
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
2 participants
@rnicoll @patricklodder