-
Notifications
You must be signed in to change notification settings - Fork 3k
Update payment protocol to match Dogecoin #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… network name Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net.
Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
greenbigfrog
suggested changes
Jan 10, 2018
src/qt/paymentrequest.proto
Outdated
@@ -1,24 +1,25 @@ | |||
// | |||
// Simple Bitcoin Payment Protocol messages | |||
// Simple Dogecoin Payment Protocol messages | |||
// Derived fromthe Bitcoin Payment Protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the
langerhans
approved these changes
Jan 20, 2018
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Feb 3, 2018
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Feb 4, 2018
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Sep 19, 2018
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Oct 13, 2018
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Oct 13, 2018
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Apr 21, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Apr 28, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
May 11, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
May 18, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Jul 13, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Jul 14, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
rnicoll
pushed a commit
to rnicoll/dogecoin
that referenced
this pull request
Jul 14, 2019
* Revised payment request handling to use genesis block hash instead of network name, enabling support for more networks that just Bitcoin main and test net. * Disable payment protocol certificate unit tests; we don't modify this code, and regenerating the test data is likely to be significantly time consuming. Will re-enable once discussion on spec is concluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.