Skip to content

Enforce minor Dogecoin parameters #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2018
Merged

Enforce minor Dogecoin parameters #1427

merged 3 commits into from
Jan 20, 2018

Conversation

rnicoll
Copy link
Contributor

@rnicoll rnicoll commented Jan 8, 2018

  • Enable block constraints properly to reflect that Doge always had BIP16 and BIP30
  • Update time-based constants including prune block size and fork detection parameters

patricklodder and others added 3 commits January 8, 2018 22:33
@patricklodder
Enable block constraints properly
159c12c 
BIP16 and BIP30 have both been enabled on Dogecoin since inception
and should not be conditional.
Update fork detection parameters for Dogecoin block time
d83eb4a 
I've multiplied fork detection parameters by 5 - the wall clock time elapsed for "long" forks
is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1
minute block times.
Update time-based constants
ca3a26d 
This updated various time-based constants to more closely reflect values
appropriate to Dogecoin:

* Minimum number of blocks and blockchain size are increased for
pruning. In comparison to Bitcoin this uses 24 hours as a minimum,
rather than 48, although given blocks are rarely full this likely
reflects a lot longer in reality.
@rnicoll rnicoll requested a review from a team January 8, 2018 22:35
@Dafeesh
Copy link

Dafeesh commented Jan 9, 2018

I believe hard fork conditions were kept in for historical (or theoretical replay purposes). At least that's the reason why Bitcoin leaves them in. Should Dogecoin keep them in, too? I'm honestly not sure.

@rnicoll
Copy link
Contributor Author

rnicoll commented Jan 9, 2018

You mean the BIP16/BIP30 conditions? I'm leaving the code in but disabled because it makes it easier to re-apply the patches for later versions.

@rnicoll rnicoll merged commit af5b9ae into dogecoin:1.14-dev Jan 20, 2018
@rnicoll rnicoll deleted the 1.14/bip-enforcement branch January 20, 2018 16:39
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 3, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
1b100e5 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 3, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
3cb0893 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 4, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
9f358dc 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Sep 19, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
2860c4b 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
fc54e62 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
Enforce minor Dogecoin parameters (dogecoin#1427)
1439123 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 21, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
6146af2 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 21, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
7359040 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 28, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
7da2ab2 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request May 11, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
ad59eaa 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request May 18, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
80f1b74 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 13, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
6136799 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 14, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
5707a37 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 14, 2019
Enforce minor Dogecoin parameters (dogecoin#1427)
bfbb78b 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request May 30, 2021
Enforce minor Dogecoin parameters (dogecoin#1427)
29a3127 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jun 2, 2021
Enforce minor Dogecoin parameters (dogecoin#1427)
a41e0a7 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jun 2, 2021
Enforce minor Dogecoin parameters (dogecoin#1427)
aba0b91 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 4, 2021
Enforce minor Dogecoin parameters (dogecoin#1427)
e028a91 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 4, 2021
Enforce minor Dogecoin parameters (dogecoin#1427)
c6e3b41 
* Minimum number of blocks and blockchain size are increased for pruning. In comparison to Bitcoin this uses 24 hours as a minimum, rather than 48, although given blocks are rarely full this likely reflects a lot longer in reality.
* Multiply fork detection parameters by 5. The wall clock time elapsed for "long" forks is therefore half that of Bitcoin, but IMHO those figures are excessive for a chain with 1 minute block times.
* BIP16 and BIP30 have both been enabled on Dogecoin since inception and should not be conditional.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 15, 2021
@xanimo
5x consensusParams.nPowTargetSpacing and BLOCK_DOWNLOAD_WINDOW in net…
d2a32ec 
…_processing and validation.h in order to match MIN_BLOCKS_TO_KEEP bumped in dogecoin#1427
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
5x consensusParams.nPowTargetSpacing and BLOCK_DOWNLOAD_WINDOW in net…
8cb076b 
…_processing and validation.h in order to match MIN_BLOCKS_TO_KEEP bumped in dogecoin#1427
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
a948cb8 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
00f79f2 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
d7fea5e 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
5a32a90 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
640e3dd 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
d7665bd 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
b6b59f7 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
c2da80b 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
f68b4d1 
reworked test to accomodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
xanimo added a commit to xanimo/dogecoin that referenced this pull request Oct 18, 2021
@xanimo
qa: fixes pruning test
cdd376c 
reworked test to accommodate changes made in dogecoin#1427

bumps BLOCK_DOWNLOAD_WINDOW from 1024 to 1440

adds MIN_BLOCK_DOWNLOAD_MULTIPLIER to net_processing in order to
bump consensus.nPowTargetSpacing from 1 to 10 second blocks in regtest
as well as nCalculatedDlWindow when using debug=net flag.
@xanimo xanimo mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langerhans langerhans langerhans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnicoll @Dafeesh @langerhans @patricklodder