Skip to content

Conversation

langerhans
Copy link
Member

This makes all unit tests green. For the blockencodings tests I wasn't quite sure if I should use a legacy or an aux version, but using an aux version makes them fail even harder cause the generated blocks do not contain auxpow data. I feel like this is not an issue here as we have specific auxpow tests.

@langerhans langerhans added this to the 1.14 milestone Dec 28, 2017
@langerhans langerhans requested a review from rnicoll December 28, 2017 19:17
@langerhans langerhans merged commit 632ce09 into dogecoin:1.14-dev Dec 28, 2017
@langerhans langerhans deleted the 1.14-dev-testfixes branch December 28, 2017 21:41
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jan 1, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jan 2, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 3, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 4, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Sep 19, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 18, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 19, 2018
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 3, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 3, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 3, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 21, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 28, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request May 11, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 13, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 14, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 14, 2019
* Fix BlockEncodings test by setting a legacy block version

* Fix RPC test by adding missing RPC call

* Add missing regtest genesis hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants