Skip to content

Conversation

rnicoll
Copy link
Contributor

@rnicoll rnicoll commented Jan 10, 2018

Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.

Load AuxPoW blocks from index correctly, by setting the version on the block before
trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never
loaded because the check always failed.
@rnicoll rnicoll added this to the 1.14 milestone Jan 10, 2018
@rnicoll rnicoll requested a review from langerhans January 10, 2018 23:09
@rnicoll
Copy link
Contributor Author

rnicoll commented Jan 10, 2018

This should address #1442 although I don't have an easy reproduction case, so hard to be entirely sure.

Copy link
Member

@langerhans langerhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the auxpow rpc tests, so it works.

@rnicoll rnicoll merged commit cd7d2a3 into dogecoin:1.14-dev Jan 11, 2018
@rnicoll rnicoll deleted the 1.14/block-header-loading branch January 11, 2018 21:04
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 3, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 3, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Feb 4, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Sep 19, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 13, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 17, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 18, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Oct 19, 2018
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 3, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 3, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 21, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 21, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Apr 28, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request May 11, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 13, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
rnicoll pushed a commit to rnicoll/dogecoin that referenced this pull request Jul 14, 2019
Load AuxPoW blocks from index correctly, by setting the version on the block before trying to check if it's AuxPoW. Previously the AuxPoW part of the block was never loaded because the check always failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants