feat: implement recipients autosuggestions #1923

catalinpit · 2025-07-25T06:04:18Z

Description

This pull request introduces recipient autosuggestions for the email and name fields in the document editor, when creating or editing documents. It allows users to select recipients from their previous document recipients and team members.

The changes include a new AutocompleteInput component with full keyboard navigation (arrow keys for navigation, enter to select, escape to close).

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

vercel · 2025-07-25T06:04:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stg-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 6, 2025 8:38am

4 Skipped Deployments

Name	Status	Updated (UTC)
prd-app	⬜️ Ignored (Inspect)	Aug 6, 2025 8:38am
prd-docs	⬜️ Ignored (Inspect)	Aug 6, 2025 8:38am
prd-openpage-api	⬜️ Ignored (Inspect)	Aug 6, 2025 8:38am
stg-app	⬜️ Ignored (Inspect)	Aug 6, 2025 8:38am

coderabbitai · 2025-07-25T06:04:27Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/add-recipient-autosuggestions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-25T06:05:59Z

🚨 @catalinpit has 7 pull requests awaiting review. Please consider reviewing them when possible. 🚨

Mythie · 2025-07-29T11:09:21Z

It would be cool to grab team members in the suggestions, they way we could do it is:

Grab at most 5 recipient suggestions at all times
Also attempt to grab 1 team member suggestion

If a team member suggestion could be found then we will show 4 recipient suggestions and 1 team member suggestion, otherwise just show all 5 team member suggestions.

catalinpit · 2025-08-05T12:34:42Z

packages/lib/server-only/recipient/get-recipient-suggestions.ts

+    take: 5,
+  });
+
+  if (teamId) {


this if statement may be redundant

catalinpit · 2025-08-05T12:37:43Z

packages/trpc/server/recipient-router/router.ts

+      const { query } = input;
+
+      ctx.logger.info({
+        input: {


the logger may need more info

github-actions · 2025-08-06T08:34:22Z

🚨 @catalinpit has 7 pull requests awaiting review. Please consider reviewing them when possible. 🚨

catalinpit · 2025-08-06T08:34:32Z

packages/trpc/server/recipient-router/find-recipient-suggestions.ts

+      },
+    });
+
+    const suggestions = await getRecipientSuggestions({


should the code from the get-recipient-suggestions server file be here or how it is now with the code split? trying to understand the new way of tRPC-ing.

catalinpit · 2025-08-06T08:34:48Z

packages/trpc/server/recipient-router/find-recipient-suggestions.ts

+
+    ctx.logger.info({
+      input: {
+        query,


more logger info?

feat: implement recipients autosuggestions

194ac7f

vercel bot deployed to Preview – stg-docs July 25, 2025 06:07 View deployment

vercel bot had a problem deploying to Preview – stg-app July 25, 2025 06:07 Failure

feat: created a new auto suggestion UI component

6ea379d

vercel bot deployed to Preview – stg-docs August 1, 2025 12:46 View deployment

catalinpit added 2 commits August 1, 2025 16:39

chore: better naming

2796c28

chore: more cleanup

301cd8a

vercel bot deployed to Preview – stg-docs August 1, 2025 13:46 View deployment

chore: implement feedback

b127ff6

vercel bot deployed to Preview – stg-docs August 4, 2025 12:06 View deployment

chore: polish

59e36f9

vercel bot deployed to Preview – stg-docs August 5, 2025 06:27 View deployment

chore: polish

e23e56b

vercel bot deployed to Preview – stg-docs August 5, 2025 06:38 View deployment

feat: convert the name field too

e0fdfdd

vercel bot deployed to Preview – stg-docs August 5, 2025 09:23 View deployment

chore: some improvements

a64a7d8

vercel bot deployed to Preview – stg-docs August 5, 2025 12:41 View deployment

chore: some improvements

d589e67

catalinpit commented Aug 6, 2025

View reviewed changes

vercel bot deployed to Preview – stg-docs August 6, 2025 07:36 View deployment

chore: use the new way of trpc

342562a

catalinpit marked this pull request as ready for review August 6, 2025 08:32

Merge branch 'main' into feat/add-recipient-autosuggestions

ed4118b

catalinpit commented Aug 6, 2025

View reviewed changes

catalinpit requested review from dguyen, ephraimduncan and Mythie August 6, 2025 08:35

vercel bot deployed to Preview – stg-docs August 6, 2025 08:38 View deployment

Mythie approved these changes Aug 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: implement recipients autosuggestions #1923

feat: implement recipients autosuggestions #1923

Uh oh!

catalinpit commented Jul 25, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

Mythie commented Jul 29, 2025

Uh oh!

catalinpit Aug 5, 2025

Uh oh!

catalinpit Aug 5, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

catalinpit Aug 6, 2025

Uh oh!

catalinpit Aug 6, 2025

Uh oh!

Uh oh!

feat: implement recipients autosuggestions #1923

Are you sure you want to change the base?

feat: implement recipients autosuggestions #1923

Uh oh!

Conversation

catalinpit commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

vercel bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

Mythie commented Jul 29, 2025

Uh oh!

catalinpit Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

catalinpit Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

catalinpit Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

catalinpit Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

catalinpit commented Jul 25, 2025 •

edited

Loading

vercel bot commented Jul 25, 2025 •

edited

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)