-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
help wantedExtra attention is neededExtra attention is neededstatus: assignedIssue has been assignedIssue has been assignedtype: enhancementEnhancing a existing featureEnhancing a existing feature
Description
Describe the improvement you are suggesting in detail
Currently it takes quite a while for ESLint to run during our precommit checks, we've attempted doing this with lint-staged with the following:
- The entire repository being linted
- Just the staged files being linted in one command e.g.
eslint --fix a.ts b.ts c.ts
- Just the staged files being linted in multiple commands e.g.
eslint --fix a.ts && eslint --fix b.ts
Additional Information & Alternatives (optional)
This super long precommit time can scare off contributors and makes general development painful since you can be stuck on the linting stage for seconds up to minutes depending on the size of your commit (yes I know keep commits small, I'm sorry!).
Improving this will be a net benefit to DX for both contributors and the Documenso team.
Do you want to work on this improvement?
No
Please check the boxes that apply to this improvement suggestion.
- I have searched the existing issues and improvement suggestions to avoid duplication.
- I have provided a clear description of the improvement being suggested.
- I have explained the rationale behind this improvement.
- I have included any relevant technical details or design suggestions.
- I understand that this is a suggestion and that there is no guarantee of implementation.
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededstatus: assignedIssue has been assignedIssue has been assignedtype: enhancementEnhancing a existing featureEnhancing a existing feature