Skip to content

Use narrower return types for convertTo*Value methods #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Use narrower return types for convertTo*Value methods #5856

merged 1 commit into from
Jan 5, 2023

Conversation

MidnightDesign
Copy link
Contributor

Q A
Type improvement
Fixed issues

Summary

Narrows down the mixed return type from Type in extending classes.

@MidnightDesign

This comment was marked as resolved.

Sign in to view
@greg0ire greg0ire added this to the 3.6.0 milestone Jan 5, 2023
@greg0ire greg0ire merged commit db068df into doctrine:3.6.x Jan 5, 2023
@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2023

Thanks @MidnightDesign !

@MidnightDesign MidnightDesign deleted the json-type-return-type branch January 5, 2023 23:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MidnightDesign @greg0ire @SenseException