Skip to content

Provide upgrade path to new ORMSetup::create* signature #12022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Provide upgrade path to new ORMSetup::create* signature #12022

merged 2 commits into from
Jun 27, 2025

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jun 25, 2025 •
edited
Loading

Currently we have ORMSetup::create*Configuration methods with a
$proxyDir argument that is used to configure the proxy directory, but
also as a seed for generating a namespace for cache systems.

Since these methods could be used with named arguments, renaming the
argument is not really an option and we need separate methods.

@greg0ire greg0ire mentioned this pull request Jun 25, 2025
Merged
@greg0ire
Copy link
Member Author

It seems that $proxyDir is used to derive a namespace for some cache implementations:

orm/src/ORMSetup.php

Lines 104 to 119 in 92e2f6d

$namespace = 'dc2_' . md5($proxyDir);
if (extension_loaded('apcu') && apcu_enabled()) {
return new ApcuAdapter($namespace);
}
if (MemcachedAdapter::isSupported()) {
return new MemcachedAdapter(MemcachedAdapter::createConnection('memcached://127.0.0.1'), $namespace);
}
if (extension_loaded('redis')) {
$redis = new Redis();
$redis->connect('127.0.0.1');
return new RedisAdapter($redis, $namespace);
}

Not sure what should become of this 🤔

Should we use the same namespace all the time, or should we rename $proxyDir to $cacheNamespaceSeed? It would seem that $proxyDir was reused for convenience because you want to change both things every time you deploy.

@greg0ire greg0ire marked this pull request as draft June 25, 2025 21:34
@greg0ire
Copy link
Member Author

should we rename $proxyDir to $cacheNamespaceSeed?

I went with this solution.

@greg0ire greg0ire force-pushed the depr-proxy-dir branch 2 times, most recently from c1cd685 to fe9a1de Compare June 25, 2025 22:10
@greg0ire
Provide upgrade path to new ORMSetup::create* signature
76852cf 
Currently we have ORMSetup::create*Configuration methods with a
$proxyDir argument that is used to configure the proxy directory, but
also as a seed for generating a namespace for cache systems.

Since these methods could be used with named arguments, renaming the
argument is not really an option and we need separate methods.
@greg0ire greg0ire marked this pull request as ready for review June 26, 2025 05:39
@greg0ire greg0ire added this to the 3.5.0 milestone Jun 27, 2025
@greg0ire greg0ire merged commit 60ff966 into doctrine:3.5.x Jun 27, 2025
86 checks passed
@greg0ire greg0ire deleted the depr-proxy-dir branch June 27, 2025 06:13
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException