Skip to content

Increasing short commit hash length is a breaking change #479

@RobinDaugherty

Description

@RobinDaugherty

Contributing guidelines

I've found a bug, and:

  • The documentation does not mention anything about my problem
  • There are no open or closed issues that are related to my problem

Description

#467 increased the default length of the commit hash created by the sha directive

This was released in v5.6.0 which made it immediately apply to everyone whose workflow specified release v5 in their actions.

This change unfortunately broke my workflows, because other parts of our workflows were hard-coded to match the size of the tags created by this action.

Please consider pulling this release and re-releasing it as v6.

Expected behaviour

v5 creates short "sha" tags with 7-character commit hash

Actual behaviour

v5 suddenly creates short "sha" tags with 12-character commit hash

Repository URL

No response

Workflow run URL

No response

YAML workflow

- name: Docker image metadata
  id: metadata
  uses: docker/metadata-action@v5
  with:
    images: |
      ${{ steps.ghcr_image_name.outputs.name }}
    tags: |
      type=ref,event=branch
      type=ref,event=pr
      type=semver,pattern={{major}}.{{minor}}.{{patch}}
      type=sha

- name: Get deployment tag
  id: get_deployment_tag
  # The following variables are made available to subsequent jobs to be used to find the specific Docker image that was built and pushed by this job.
  run: |
    echo "deployment_tag=sha-$(echo ${{ github.sha }} | cut -c1-7)" >> $GITHUB_OUTPUT
    echo "build_image=${{ steps.ghcr_image_name.outputs.name }}:sha-$(echo ${{ github.sha }} | cut -c1-7)" >> $GITHUB_OUTPUT

Workflow logs

No response

BuildKit logs


Additional info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions