Add ListenerSink to allow users to watch events passing through sinks #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful, e.g. for metrics Signed-off-by: Elliot Pahl <elliot.pahl@gmail.com>
This was referenced Mar 16, 2018
|
This looks good. The only question I have is about error handling: do we want a way to have the listener detect the error on write? |
Adirio
reviewed
May 2, 2018
| ls := &ListenerSink{ | ||
| dst: dst, | ||
| ListenFunc: fn, | ||
| closed: false, |
|
@dmcgowan @manishtomar ptal |
|
@thaJeztah Could you add me as reviewer? |
|
@manishtomar sorry, don't have write access to this repository myself 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful, e.g. for metrics.
This will allow the registry to use queue from this package, per distribution/distribution#1553 and distribution/distribution#2550.
Signed-off-by: Elliot Pahl elliot.pahl@gmail.com