Skip to content

Reference docs URL scheme #19370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

Reference docs URL scheme #19370

merged 2 commits into from
Feb 21, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 9, 2024 •
edited
Loading

Proposed changes

Updates the URL paths for:

CLI reference /engine/reference/commandline/[command[_subcommand]] -> /reference/cli/docker/[cmd[/subcommand]/]
dockerd /engine/reference/commandline/dockerd/ -> /reference/cli/dockerd/
Dockerfile /engine/reference/builder/ -> /reference/dockerfile/

Related issues (optional)

@netlify Netlify
Copy link

netlify bot commented Feb 9, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8e14736
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65d5c1a99687bc0008fa26af
😎 Deploy Preview https://deploy-preview-19370--docsdocker.netlify.app/reference/dockerfile
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/compose Relates to docker-compose.yml spec or docker-compose binary area/networking Relates to anything around networking area/hub Issue affects Docker Hub area/build Relates to Dockerfiles or docker build command area/swarm Issue affects swarm and clustering functionality of docker area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/cli Relates to the CLI client area/get-started Relates to get started and onboarding docs area/configuration area/extensions Relates to Docker Extensions area/scout Relates to Docker Scout hugo Updates related to hugo dependencies Vendoring, packaging updates labels Feb 9, 2024
@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch from 4ceb80a to 263df31 Compare February 9, 2024 16:02
@github-actions github-actions bot added area/install Relates to installing a product area/storage Relates to storage, volumes area/api Relates to Docker API docs labels Feb 9, 2024
@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch 4 times, most recently from 54e3897 to a013ad5 Compare February 9, 2024 16:48
@dvdksn dvdksn changed the title cli reference urlscheme Reference docs URL scheme Feb 9, 2024
@dvdksn dvdksn marked this pull request as ready for review February 9, 2024 16:53
@dvdksn dvdksn mentioned this pull request Feb 11, 2024
Merged
crazy-max
crazy-max previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch 2 times, most recently from 89dc223 to 4bcd5dd Compare February 13, 2024 19:04
@dvdksn dvdksn mentioned this pull request Feb 13, 2024
Merged
@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch from 4bcd5dd to 3425633 Compare February 13, 2024 19:11
@dvdksn dvdksn mentioned this pull request Feb 15, 2024
Merged
@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch 4 times, most recently from f3fa70d to 3799938 Compare February 21, 2024 09:24
@dvdksn
cli: change reference docs url paths
f3b44a4 
Moves the reference documentation to a new subpath, from /engine/ to /reference/
@dvdksn
vendor: upgrade buildx, cli, compose
8e14736 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the cli-reference-urlscheme branch from 3799938 to 8e14736 Compare February 21, 2024 09:25
@dvdksn dvdksn merged commit d10c667 into docker:main Feb 21, 2024
@dvdksn dvdksn deleted the cli-reference-urlscheme branch February 21, 2024 10:05
@crazy-max crazy-max mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

@aevesdocker aevesdocker Awaiting requested review from aevesdocker

@craig-osterhout craig-osterhout Awaiting requested review from craig-osterhout

@stephaurelio stephaurelio Awaiting requested review from stephaurelio

Assignees
No one assigned
Labels
area/api Relates to Docker API docs area/build Relates to Dockerfiles or docker build command area/cli Relates to the CLI client area/compose Relates to docker-compose.yml spec or docker-compose binary area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions area/get-started Relates to get started and onboarding docs area/hub Issue affects Docker Hub area/install Relates to installing a product area/networking Relates to anything around networking area/scout Relates to Docker Scout area/storage Relates to storage, volumes area/swarm Issue affects swarm and clustering functionality of docker dependencies Vendoring, packaging updates hugo Updates related to hugo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdksn @crazy-max