Skip to content

[20.10 backport] bump Compose version to v2.12.1 #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[20.10 backport] bump Compose version to v2.12.1 #775

wants to merge 1 commit into from

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 21, 2022

(cherry picked from commit a7226ba)
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

@glours
bump Compose version to v2.12.1
c0028a5 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
(cherry picked from commit a7226ba)
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested a review from thaJeztah October 21, 2022 15:00
@glours glours self-assigned this Oct 21, 2022
StefanScherer
StefanScherer approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah changed the title bump Compose version to v2.12.1 [20.10 backport] bump Compose version to v2.12.1 Oct 21, 2022
@thaJeztah
Copy link
Member

thaJeztah commented Oct 21, 2022 •
edited
Loading

Ah, dang.. we need to fix something; this won't work with go1.18;

builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ)

/go/pkg/mod/github.com/docker/docker@v20.10.3-0.20221021122114-f9cb47a052be+incompatible/builder/remotecontext/git/gitutils.go:216:23: cmd.Environ undefined (type *exec.Cmd has no field or method Environ)
make[2]: *** [Makefile:51: build] Error 2
make[2]: Leaving directory '/root/build-deb/compose'
make[1]: *** [debian/rules:20: override_dh_auto_build] Error 2
make[1]: Leaving directory '/root/build-deb'
make: *** [debian/rules:123: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
Makefile:74: recipe for target 'raspbian-bullseye' failed
make[1]: *** [raspbian-bullseye] Error 2
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-775/deb'
Makefile:84: recipe for target 'raspbian-bullseye' failed
make: *** [raspbian-bullseye] Error 2
script returned exit code 2

This was referenced Oct 21, 2022
Merged
Merged
Merged
@milas milas mentioned this pull request Oct 21, 2022
Merged
@thaJeztah
Copy link
Member

superseded by #777

@thaJeztah thaJeztah closed this Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

1 more reviewer

@StefanScherer StefanScherer StefanScherer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@glours glours

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glours @thaJeztah @StefanScherer