deprecate blkio-weight options with cgroups v1 #2908
Conversation
|
@AkihiroSuda perhaps you could have a look; I'm somewhat confused what's deprecated, and what not (and/or if this has already been removed?). Looking at https://github.com/torvalds/linux/blob/fb5772cbfe48575711bf789767d561582376f7f1/Documentation/cgroup-v1/blkio-controller.txt#L91-L97 these are still listed Are they still functional? Only with v2, or also with v1, or have they been fully removed? Do we need to update the checks we use to print the warnings (as shown in docker/for-linux#1175)? |
|
Do you also know which kernel version this was deprecated / removed in? |
|
cgroup v2 still has |
docs/deprecated.md
Outdated
|
|
||
| Specifying blkio weight (`docker run --blkio-weight` and `docker run --blkio-weight-device`) | ||
| is now marked as deprecated when using cgrous v1, because the corresponding features | ||
| were marked [deprecated in the Linux kernel](https://github.com/torvalds/linux/commit/f382fb0bcef4c37dc049e9f6963e3baf204d815c). |
Should it be removed from this page? https://github.com/torvalds/linux/blob/23aa16489c06e6739c7c99e9fdccf723d2691a5d/Documentation/admin-guide/cgroup-v1/blkio-controller.rst#proportional-weight-policy-files or is that expected to still be there (and converted to |
Do we need to make changes on our side to perform that conversion? (Haven't checked) |
These options were deprecated and removed in the Linux kernel v5.0 and up in; - torvalds/linux@f382fb0 - torvalds/linux@fb5772c - torvalds/linux@23aa164 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
30f6aa7 to
fb2ea09
Compare
|
updated; PTAL (hope the description of the |
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
=======================================
Coverage 57.05% 57.05%
=======================================
Files 297 297
Lines 18653 18653
=======================================
Hits 10643 10643
Misses 7151 7151
Partials 859 859 |
Seems yes
Conversion is done by runc, not by kernel nor Moby |
Thanks Akihiro! (sorry for all the questions 😅) |
|
@silvin-lubecki PTAL |
| **Deprecated in Release: v20.10** | ||
|
|
||
| Specifying blkio weight (`docker run --blkio-weight` and `docker run --blkio-weight-device`) | ||
| is now marked as deprecated when using cgrous v1 because the corresponding features |
There was a problem hiding this comment.
little typo: cgrous cgroups
relates to moby/moby#41252 (comment)
These options were deprecated and removed in the Linux kernel v5.0 and up in;
- Description for the changelog
- Deprecate blkio-weight options with cgroups v1