Skip to content

[23.0 backport] Handle empty DOCKER_BUILDKIT like unset #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

[23.0 backport] Handle empty DOCKER_BUILDKIT like unset #4217

merged 1 commit into from
Apr 20, 2023

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 19, 2023

This fixes the cli erroring out if the variable is set to an empty value.
The behavior for empty variable will be the same as if it was undefined.

$ export DOCKER_BUILDKIT=
$ docker version
DOCKER_BUILDKIT environment variable expects boolean value: strconv.ParseBool: parsing "": invalid syntax

- What I did

- How I did it
Use os.Getenv instead of os.LookupEnv

- How to verify it

DOCKER_BUILDKIT= docker version

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland
Handle empty DOCKER_BUILDKIT like unset
c648e0b 
This fixes the cli erroring out if the variable is set to an empty
value.

```
$ export DOCKER_BUILDKIT=
$ docker version
DOCKER_BUILDKIT environment variable expects boolean value: strconv.ParseBool: parsing "": invalid syntax
```

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit ff7f76a)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added area/builder kind/bugfix PR's that fix bugs labels Apr 19, 2023
@vvoland vvoland added this to the 23.0.5 milestone Apr 19, 2023
thaJeztah
thaJeztah approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ced769f into docker:23.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@laurazard laurazard laurazard approved these changes

Assignees
No one assigned
Labels
area/builder kind/bugfix PR's that fix bugs
Projects
None yet
Milestone
23.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@vvoland @thaJeztah @laurazard