Skip to content

Revert "Apply newly loaded envvars to DockerCli and APIClient" #9792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Revert "Apply newly loaded envvars to DockerCli and APIClient" #9792

merged 1 commit into from
Aug 26, 2022

Conversation

milas
Copy link
Contributor

@milas milas commented Aug 26, 2022

What I did
Revert #9745 that introduced support for reading DOCKER_HOST & friends from .env files but broke TLS options.

Related issue
Fixes #9789.

@milas
Revert "Merge pull request docker#9745 from ulyssessouza/apply-newly-…
3460d02 
…loaded-envvars"

This reverts commit 6fe34c4, reversing
changes made to 10cfd55.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas requested a review from a team August 26, 2022 19:55
@milas milas self-assigned this Aug 26, 2022
nicksieger
nicksieger approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milas milas merged commit f3e0c38 into docker:v2 Aug 26, 2022
@milas milas deleted the revert-docker-host-env branch August 26, 2022 20:03
This was referenced Sep 6, 2022
Closed
Merged
@ulyssessouza ulyssessouza mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nicksieger nicksieger nicksieger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@milas milas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when setting DOCKER_HOST on Compose 2.10.1
2 participants
@milas @nicksieger